Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boto3/dynamo): use tcp_keepalive #2926

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Nov 6, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Use tcp_keepalive when creating dynamodb resource

How did you test this code?

Ran this code locally to make sure it works

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:56am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:56am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:56am

@gagantrivedi
Copy link
Member Author

Closes #2846

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Uffizzi Preview deployment-40113 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3732e67) 95.63% compared to head (b460236) 95.63%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2926   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files        1012     1012           
  Lines       29137    29139    +2     
=======================================
+ Hits        27866    27868    +2     
  Misses       1271     1271           
Files Coverage Δ
api/environments/dynamodb/dynamodb_wrapper.py 96.03% <100.00%> (+0.03%) ⬆️
...s/dynamodb/tests/test_dynamodb_identity_wrapper.py 98.22% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants