Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add seats to next invoice #2977

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This simple fix of flipping a boolean pushes the invoice date for the new seat to the next billing period to satisfy this ticket.

How did you test this code?

I connected my local running code to the flagsmith-test chargebee account and manually added a seat then verified that the unbilled charges increased, see below:

image

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 8:17pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Nov 15, 2023 8:17pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 8:17pm

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Uffizzi Preview deployment-40833 was deleted.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99180cd) 95.54% compared to head (2c0b5a9) 95.56%.
Report is 6 commits behind head on main.

Files Patch % Lines
...ns/0008_add_manage_segment_overrides_permission.py 88.23% 2 Missing ⚠️
api/app/settings/local.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2977      +/-   ##
==========================================
+ Coverage   95.54%   95.56%   +0.01%     
==========================================
  Files        1013     1014       +1     
  Lines       29331    29421      +90     
==========================================
+ Hits        28025    28116      +91     
+ Misses       1306     1305       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit e4325a8 Nov 16, 2023
20 checks passed
@matthewelwell matthewelwell deleted the feat/add_seats_to_next_invoice branch November 16, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants