Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opening the flag panel shifts the main table slightly #2994

Conversation

MatheusLasserre
Copy link
Contributor

@MatheusLasserre MatheusLasserre commented Nov 17, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Removed the "!important" from padding-right on class "modal-open", which was forcing the browser to increase the page width when the scrollbar disappears.

The issue was that every time the page had a scroll-bar, opening a modal causes a layout shift, since it makes the scroll-bar disappears. So it was not only on the feature flag modal, but all of them.
Fixes #2984

How did you test this code?

  1. Go to any page that has a modal;
  2. Get vertical space so the scrollbar appears;
  3. Open modal.

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 4:47pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 4:47pm

Copy link

vercel bot commented Nov 17, 2023

@MatheusLasserre is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Nov 17, 2023
@matthewelwell
Copy link
Contributor

This appears to be fixing the same issue as in #2991 but with a different fix implementation. I'm not sure on the benefits / implications of one or the other here.

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Uffizzi Preview deployment-40993 was deleted.

@dabeeeenster
Copy link
Contributor

This appears to be fixing the same issue as in #2991 but with a different fix implementation. I'm not sure on the benefits / implications of one or the other here.

This one looks cleaner! Just testing

@dabeeeenster dabeeeenster added this pull request to the merge queue Nov 17, 2023
@dabeeeenster
Copy link
Contributor

Thanks!

Merged via the queue into Flagsmith:main with commit 85d980c Nov 17, 2023
16 of 18 checks passed
@MatheusLasserre
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening the flag panel shifts the main table slightly
3 participants