Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WIP Move groups of tests to proper location #3027

Merged
merged 12 commits into from
Nov 23, 2023

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Nov 23, 2023

This PR just moves tests over for three major directories. Four of the tests required updating once it was moved which I found odd, but the changes they required seemed necessary anyway.

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 5:48pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 5:48pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 5:48pm

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Uffizzi Preview deployment-41373 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (83285f0) 95.78% compared to head (09360c6) 95.88%.
Report is 1 commits behind head on main.

Files Patch % Lines
...pi/tests/unit/projects/test_unit_projects_views.py 99.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3027      +/-   ##
==========================================
+ Coverage   95.78%   95.88%   +0.09%     
==========================================
  Files        1048     1044       -4     
  Lines       30671    30663       -8     
==========================================
+ Hits        29379    29401      +22     
+ Misses       1292     1262      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit 1592919 Nov 23, 2023
20 checks passed
@zachaysan zachaysan deleted the fix/move_groups_of_tests_to_proper_location branch November 23, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants