feat(auth): integrate ldap #3031
Conversation
# Conflicts: # .github/workflows/platform-docker-publish-all-features-image.yml
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Ephemeral Environment
|
matthewelwell
requested review from
a team and
khvn26
and removed request for
a team
| @@ -120,7 +120,7 @@ jobs: | |||
| context: . | |||
| build-args: | | |||
| SAML_INSTALLED=1 | |||
| POETRY_OPTS=--with saml,auth-controller | |||
| POETRY_OPTS=--with saml,auth-controller,ldap | |||
There was a problem hiding this comment.
Since we're resorting to a private git dependency, this step will fail without adding credentials to the git client.
See one of the solutions.
There was a problem hiding this comment.
Hmm... I was assuming that the presence of the github token secret variable would suffice here but perhaps you're right. It's working currently where we manually checkout the packages but I guess that's because we're using a pre-built action. I'll have a play with this...
There was a problem hiding this comment.
We are providing a distinct token to the checkout action for the private repos, aren't we?
There was a problem hiding this comment.
Yes, you're right, we are. Well caught, thanks!
There was a problem hiding this comment.
See successful build here.
# Conflicts: # api/poetry.lock
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
==========================================
+ Coverage 95.74% 95.89% +0.15%
==========================================
Files 1045 1039 -6
Lines 30889 30688 -201
==========================================
- Hits 29574 29429 -145
+ Misses 1315 1259 -56 ☔ View full report in Codecov by Sentry. |
matthewelwell
force-pushed
the
chore/integrate-ldap
branch
from
cb57d08
to
f3943e8
Compare
matthewelwell
force-pushed
the
chore/integrate-ldap
branch
2 times, most recently
from
dceb49c
to
b04c793
Compare
matthewelwell
force-pushed
the
chore/integrate-ldap
branch
from
b04c793
to
2d16bd2
Compare
| @@ -43,6 +43,7 @@ jobs: | |||
|
|
|||
| - name: Install poetry | |||
| run: pipx install poetry | |||
|
|
|||
There was a problem hiding this comment.
Sorry, irrelevant to this PR but it was bothering me.
Changes
Adds the flagsmith-ldap module as a dependency to the main Flagsmith application. This will be installed as a dependency as part of the flagsmith-private-cloud image build workflow.
How did you test this code?
Tests are run in flagsmith/flagsmith-ldap repository.