Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert to Core API segment evaluation #3036

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Nov 27, 2023

This reverts commit 322eb08.

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This reverts changes introduced in #2865 to eliminate an N+1 problem it supposedly adds.

How did you test this code?

Unit tests cover it.

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 11:36am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Nov 27, 2023 11:36am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 11:36am

Copy link
Contributor

github-actions bot commented Nov 27, 2023

Uffizzi Preview deployment-41503 was deleted.

@codecov-commenter
Copy link

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (1592919) 95.88% compared to head (915653b) 95.73%.
Report is 2 commits behind head on main.

Files Patch % Lines
api/segments/models.py 66.24% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3036      +/-   ##
==========================================
- Coverage   95.88%   95.73%   -0.15%     
==========================================
  Files        1044     1046       +2     
  Lines       30663    30859     +196     
==========================================
+ Hits        29401    29544     +143     
- Misses       1262     1315      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit e5058ae Nov 27, 2023
20 checks passed
@matthewelwell matthewelwell deleted the fix/revert-engine-segment-eval branch November 27, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants