Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move organisation tests to proper location #3041

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Move all of the organisations code over to the the test suite, merging with existing files where existing.

How did you test this code?

Ran the test suite locally to make sure that any conftests or other issues didn't clobber the tests.

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 2:11pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 2:11pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 2:11pm

Copy link
Contributor

github-actions bot commented Nov 27, 2023

Uffizzi Preview deployment-41516 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5058ae) 95.73% compared to head (f57becd) 95.73%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3041      +/-   ##
==========================================
- Coverage   95.73%   95.73%   -0.01%     
==========================================
  Files        1046     1044       -2     
  Lines       30859    30855       -4     
==========================================
- Hits        29544    29540       -4     
  Misses       1315     1315              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaysan zachaysan added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 34c6d07 Nov 27, 2023
20 checks passed
@zachaysan zachaysan deleted the fix/move_organisation_tests_to_proper_location branch November 27, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants