Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add group owners to missing endpoint #3080

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Nov 30, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This endpoint was missing from the previous round of work to implement group owners for features. This change adds it to the missing endpoint.

References this ticket.

How did you test this code?

Tested manually against the privilege of least concern.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 8:05pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 8:05pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 8:05pm

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Uffizzi Preview deployment-41881 was deleted.

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zachaysan zachaysan added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 8fe2ea7 Dec 1, 2023
20 checks passed
@zachaysan zachaysan deleted the fix/add_group_owners_to_missing_endpoint branch December 1, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants