Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move environments and features to test area #3081

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

Changes

This is the second last wave of moving the test code into a centralized area of the repository. These mostly move the environment tests and merging existing tests together where appropriate.

How did you test this code?

Test it locally as I moved it over. This time there were no logical failures, though there was a set of errors that were due to the --reuse-db command flag.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 6:28pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 6:28pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 6:28pm

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Uffizzi Preview deployment-41891 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2880ef5) 95.89% compared to head (02a1892) 95.88%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3081      +/-   ##
==========================================
- Coverage   95.89%   95.88%   -0.02%     
==========================================
  Files        1039     1035       -4     
  Lines       30764    30758       -6     
==========================================
- Hits        29502    29493       -9     
- Misses       1262     1265       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants