Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres/feature-analytics): use feature filter #3091

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Dec 5, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Use feature filter when fetching data for feature evaluation from Postgres

How did you test this code?

Update unit test

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 5:59am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 5:59am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 5:59am

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Uffizzi Preview deployment-42143 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dc4e14) 95.75% compared to head (14e52ab) 95.89%.
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3091      +/-   ##
==========================================
+ Coverage   95.75%   95.89%   +0.13%     
==========================================
  Files        1040     1035       -5     
  Lines       30850    30781      -69     
==========================================
- Hits        29539    29516      -23     
+ Misses       1311     1265      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit c0fc231 Dec 5, 2023
20 checks passed
@gagantrivedi gagantrivedi deleted the fix/feature-analytics branch December 5, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants