feat: add attribute to store identity overrides storage type #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
khvn26
approved these changes
Dec 7, 2023
matthewelwell
force-pushed
the
feat/add-attribute-to-project-for-identity-override-storage
branch
from
979484d
to
6fdcfe6
Compare
matthewelwell
deleted the
feat/add-attribute-to-project-for-identity-override-storage
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3109 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 1037 1038 +1
Lines 30882 30910 +28
=======================================
+ Hits 29623 29651 +28
Misses 1259 1259 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add an attribute to the Project model to store where to retrieve the identity overrides from.
This field will be modified by the migration process (tbd) which will migrate the overrides from the identity records in the
flagsmith_identitiestable to items in theflagsmith_overridestable. It will subsequently be used by the Core API to determine where to write / read the identity override.How did you test this code?
N/a