Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump rbac to fix import issue #3128

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: bump rbac to fix import issue #3128

merged 2 commits into from
Dec 11, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Dec 11, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Bump rbac to fix changes added here: 0604ec1
Fix merge_group workflow

How did you test this code?

Installing rbac to make sure the import works

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 10:56am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 10:56am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2023 10:56am

Copy link
Contributor

github-actions bot commented Dec 11, 2023

Uffizzi Preview deployment-42515 was deleted.

Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a9cd7c) 95.95% compared to head (c183a86) 96.07%.
Report is 2 commits behind head on main.

❗ Current head c183a86 differs from pull request most recent head 4c85c46. Consider uploading reports for the commit 4c85c46 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   95.95%   96.07%   +0.12%     
==========================================
  Files        1053     1053              
  Lines       31588    31601      +13     
==========================================
+ Hits        30311    30362      +51     
+ Misses       1277     1239      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants