fix: show falsy values in identity overrides #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
khvn26,
a team and
kyle-ssg
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
matthewelwell
changed the title
|
Uffizzi Preview |
khvn26
approved these changes
Dec 12, 2023
matthewelwell
deleted the
fix/show-falsy-values-in-identity-overrides
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensures that (valid) falsy values are shown in the identity override rows on the identity overrides tab in the feature modal.
How did you test this code?
Ran the FE locally against staging with a known override of
falseand confirmed that it is displayed.