Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing f-string from app_analytics models #3155

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

While looking into our various databases on the backend I noticed these strings were missed and quickly fixed them.

How did you test this code?

The change is simple enough to rely on CI / common sense.

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 13, 2023 4:25pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 4:25pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 4:25pm

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Uffizzi Preview deployment-42754 was deleted.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (76cc152) 96.10% compared to head (e4373f3) 96.10%.
Report is 5 commits behind head on main.

Files Patch % Lines
api/app_analytics/models.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3155   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files        1058     1058           
  Lines       31882    31882           
=======================================
  Hits        30641    30641           
  Misses       1241     1241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 58d6589 Dec 14, 2023
21 checks passed
@matthewelwell matthewelwell deleted the fix/add_missing_f_string branch December 14, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants