Archiving Flags

[dabeeeenster]

Overview

We have had feedback that admin users often want to tidy up/clear up old flags, but are worried about removing the flag from SDK API requests (due to aspects like old Mobile app versions needing old/stale flags).

Proposal

Add an Archive button to the flag modal. Archiving a flag removes it from the default flag list for a project. If an environment has any archived flags, indicate the number here:

e.g.

🚀 Features 9 Archived Flags

The "9 Archived Flags" button would act as a toggle. Clicking on "9 Archived Flags" would toggle showing/hiding the archived flags in the list.

[gagantrivedi]

Since this endpoint is paginated(with page size of 10 and no way for client to change that, although we can enable that) I think we have to implement pagination for this endpoint.

[dabeeeenster]

@kyle-ssg how is the main list of features called from the front end dashboard? Is it doing paging in any way?

[matthewelwell]

@dabeeeenster @gagantrivedi I remembered this morning (and verified) that we hacked this for production only. Check out app.settings.production, it has this line:

REST_FRAMEWORK["PAGE_SIZE"] = 999

[dabeeeenster]

OK yes lets fix that 🤣

[dabeeeenster]

Needs Front End @kyle-ssg

[kyle-ssg]

Note: for tech debt I'll be adding page_size=999 as a get param to /projects/:id/features in order to remove the need for the global page_size param. (Done in #357)

[kyle-ssg]

Frontend tested on staging and pushed live under the flag archive_flags #356

[dabeeeenster]

Archived flags should be hidden by default. Archiving flags on staging works but they are still showing in the default list.

[kyle-ssg]

Not true?  Archived toggle is deselected by default.

[dabeeeenster]

I see this as the default page:

Also toggling archive has no effect for me

[kyle-ssg]

And if you select archived does it show an additional 2 flags?

[dabeeeenster]

Video

Nothing in JS console

[kyle-ssg]

Ok, that only happens in the case where no tags are selected , fixed here #367

[gagantrivedi]

@dabeeeenster safe to close?