Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postgres/analytics): Add task to clean-up old data #3170

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Dec 15, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add recurring task to clean up old analytics data

How did you test this code?

Covered by unit tests

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 10:40am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 10:40am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 10:40am

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Uffizzi Preview deployment-42916 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79e67ee) 96.11% compared to head (167f588) 96.11%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3170   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files        1059     1059           
  Lines       32036    32074   +38     
=======================================
+ Hits        30791    30829   +38     
  Misses       1245     1245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi force-pushed the feat/clean-old-analytics-data branch 2 times, most recently from 76d9ff3 to 167f588 Compare December 15, 2023 10:34
@gagantrivedi gagantrivedi marked this pull request as ready for review December 15, 2023 10:34
@gagantrivedi gagantrivedi requested review from a team and zachaysan and removed request for a team December 15, 2023 10:34
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good and the code is straightforward 👍🏼

api/app_analytics/tasks.py Show resolved Hide resolved
@gagantrivedi gagantrivedi added this pull request to the merge queue Dec 18, 2023
Merged via the queue into main with commit 8c8ce1f Dec 18, 2023
34 checks passed
@gagantrivedi gagantrivedi deleted the feat/clean-old-analytics-data branch December 18, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants