Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new url from role groups #3178

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Dec 18, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add new URLs for role groups:

GET: organisations/{organisation_pk}/groups/{group_pk}/roles/
DELETE: organisations/{organisation_pk}/groups/{group_pk}/roles/{id}/

How did you test this code?

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 18, 2023 3:37pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Dec 18, 2023 3:37pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Dec 18, 2023 3:37pm

@github-actions github-actions bot added the api Issue related to the REST API label Dec 18, 2023
Copy link
Contributor

github-actions bot commented Dec 18, 2023

Uffizzi Preview deployment-43099 was deleted.

@novakzaballa novakzaballa marked this pull request as ready for review December 18, 2023 16:12
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fc3bce0) 96.11% compared to head (940522c) 96.11%.
Report is 2 commits behind head on main.

Files Patch % Lines
api/organisations/urls.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
- Coverage   96.11%   96.11%   -0.01%     
==========================================
  Files        1059     1059              
  Lines       32037    32076      +39     
==========================================
+ Hits        30792    30829      +37     
- Misses       1245     1247       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is good, but in the future it would be helpful to get a link to the other matching PR in the other repository.

Also, I don't really understand why RolesByGroupViewSet is importable when the other repository hasn't merged it yet, but I'll leave the merging prioritization up to you.

@novakzaballa novakzaballa linked an issue Dec 18, 2023 that may be closed by this pull request
@novakzaballa
Copy link
Contributor Author

novakzaballa commented Dec 20, 2023

This PR is good, but in the future it would be helpful to get a link to the other matching PR in the other repository.

Good point, I shared all the related PRs in Notion and communicated via Slack, since we don't have other better way to manage subtasks in GitHub. Maybe the next time I will create a specific project for large features, however, part of this work already existed when I started working on it and I didn't realize that it would be necessary to change the API at that moment.

Also, I don't really understand why RolesByGroupViewSet is importable when the other repository hasn't merged it yet, but I'll leave the merging prioritization up to you.

It works maybe because its conditional use? Even when it is a bit counterintuitive that's the way it worked for this kind of multi-repo code in the past.

@novakzaballa novakzaballa added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit eebc541 Dec 20, 2023
34 checks passed
@novakzaballa novakzaballa deleted the feat/add-new-url-for-role-groups branch December 20, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading role permissions generates 500 errors
3 participants