feat(audit): add change details to AuditLog #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewelwell
force-pushed
the
feature/1347/add-change-details-to-audit-log
branch
from
230f86e
to
77731c5
Compare
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3218 +/- ##
===========================================
- Coverage 95.90% 77.21% -18.70%
===========================================
Files 1062 1036 -26
Lines 32357 31602 -755
===========================================
- Hits 31033 24401 -6632
- Misses 1324 7201 +5877 ☔ View full report in Codecov by Sentry. |
matthewelwell
requested review from
a team and
khvn26
and removed request for
a team
matthewelwell
force-pushed
the
feature/1347/add-change-details-to-audit-log
branch
from
11b20d9
to
a09b4cf
Compare
matthewelwell
changed the title
matthewelwell
changed the title
khvn26
reviewed
Jan 3, 2024
khvn26
reviewed
Jan 3, 2024
api/audit/serializers.py
Outdated
| @swagger_serializer_method( | ||
| serializer_or_field=AuditLogChangeDetailsSerializer(many=True) | ||
| ) | ||
| def get_change_details(self, instance: AuditLog) -> typing.List[typing.Dict]: |
There was a problem hiding this comment.
Suggested change
| def get_change_details(self, instance: AuditLog) -> typing.List[typing.Dict]: | |
| def get_change_details(self, instance: AuditLog) -> typing.List[typing.Dict[str, typing.Any]: |
khvn26
approved these changes
Jan 3, 2024
matthewelwell
force-pushed
the
feature/1347/add-change-details-to-audit-log
branch
from
2f6d68a
to
8f0ac30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the change details to the API when retrieving a record from the AuditLog. To achieve this, I have added a new endpoint to retrieve an individual AuditLog record which includes a new
change_detailsattribute in the JSON response.The
change_detailsattribute contains a list, representing fields that have changed, e.g:How did you test this code?
Added 'integration' style tests for common use cases.