Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import rules from LD flags #3233

Merged
merged 22 commits into from
Feb 9, 2024
Merged

Conversation

Dogacel
Copy link
Contributor

@Dogacel Dogacel commented Jan 3, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Support importing segments from launch darkly
  • Support importing targeting rules for segments from launch darkly
  • Support importing targeting rules for feature flags from launch darkly

How did you test this code?

There are mock responses from launch darkly for importing segments and flag rules.

Copy link

vercel bot commented Jan 3, 2024

@Dogacel is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 4:54pm

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (0ef4764) 95.95% compared to head (4b29514) 95.91%.
Report is 53 commits behind head on main.

Files Patch % Lines
api/integrations/launch_darkly/services.py 92.54% 12 Missing ⚠️
api/integrations/launch_darkly/client.py 50.00% 9 Missing ⚠️
api/integrations/launch_darkly/models.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
- Coverage   95.95%   95.91%   -0.05%     
==========================================
  Files        1067     1077      +10     
  Lines       32704    33271     +567     
==========================================
+ Hits        31381    31911     +530     
- Misses       1323     1360      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Uffizzi Preview deployment-45529 was deleted.

@dabeeeenster dabeeeenster changed the title try importing rules from LD flags feat: try importing rules from LD flags Jan 3, 2024
@Dogacel Dogacel marked this pull request as ready for review January 16, 2024 20:40
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 22, 2024
@github-actions github-actions bot removed the front-end Issue related to the React Front End Dashboard label Jan 22, 2024
api/integrations/launch_darkly/client.py Outdated Show resolved Hide resolved
api/integrations/launch_darkly/client.py Show resolved Hide resolved
api/integrations/launch_darkly/models.py Show resolved Hide resolved
api/integrations/launch_darkly/models.py Outdated Show resolved Hide resolved
api/integrations/launch_darkly/services.py Outdated Show resolved Hide resolved
api/integrations/launch_darkly/services.py Outdated Show resolved Hide resolved
api/integrations/launch_darkly/services.py Outdated Show resolved Hide resolved
api/integrations/launch_darkly/services.py Show resolved Hide resolved
api/integrations/launch_darkly/services.py Show resolved Hide resolved
@Dogacel
Copy link
Contributor Author

Dogacel commented Feb 7, 2024

I am hoping the failing E2E will be handled by #3399

@matthewelwell
Copy link
Contributor

Thanks again for this @Dogacel !

@matthewelwell matthewelwell added this pull request to the merge queue Feb 9, 2024
Merged via the queue into Flagsmith:main with commit 42634ec Feb 9, 2024
18 of 21 checks passed
@matthewelwell matthewelwell changed the title feat: try importing rules from LD flags feat: import rules from LD flags Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants