Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sse/stream_access_logs): handle invalid log #3307

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jan 19, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Because we log the URL path in Fastly logs, if someone is hitting an invalid URL, we receive logs that are invalid. This pull request addresses this by logging them as warnings and moving on to the next row.

How did you test this code?

Updates unit test case to include invalid log

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 19, 2024 4:01am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 4:01am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Jan 19, 2024 4:01am

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Uffizzi Preview deployment-44632 was deleted.

@codecov-commenter
Copy link

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (f88f334) 95.94% compared to head (590d3e4) 50.99%.
Report is 10 commits behind head on main.

Files Patch % Lines
api/tests/unit/users/test_unit_users_models.py 0.00% 43 Missing ⚠️
api/features/import_export/views.py 45.45% 6 Missing ⚠️
api/features/import_export/permissions.py 28.57% 5 Missing ⚠️
api/features/import_export/tasks.py 33.33% 4 Missing ⚠️
api/integrations/rudderstack/rudderstack.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3307       +/-   ##
===========================================
- Coverage   95.94%   50.99%   -44.95%     
===========================================
  Files        1067     1001       -66     
  Lines       32613    29555     -3058     
===========================================
- Hits        31291    15073    -16218     
- Misses       1322    14482    +13160     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 0ef4764 Jan 19, 2024
21 checks passed
@gagantrivedi gagantrivedi deleted the fix/parsing-sse-logs branch January 19, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants