Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datadog): add source type name to datadog #3342

Merged
merged 17 commits into from
Feb 14, 2024

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jan 29, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds the source_type_name attribute to requests to the datadog request to display the source in the datadog dashboard as per documentation here.

How did you test this code?

Modified / added tests. Also made a manual call to the datadog API with the source_type_name parameter set to "flagsmith" to verify it was accepted (as you can see in screenshot below)

image

I also ran the FE locally to verify that the changes made in the CreateEditIntegration component work as expected.

@matthewelwell matthewelwell requested review from a team and zachaysan and removed request for a team January 29, 2024 16:20
Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 1:19pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 1:19pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 1:19pm

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c666d29) 95.91% compared to head (0ac67c4) 95.91%.

❗ Current head 0ac67c4 differs from pull request most recent head 1cf58ab. Consider uploading reports for the commit 1cf58ab to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3342   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files        1085     1086    +1     
  Lines       33677    33692   +15     
=======================================
+ Hits        32302    32317   +15     
  Misses       1375     1375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Uffizzi Preview deployment-45309 was deleted.

@matthewelwell
Copy link
Contributor Author

matthewelwell commented Feb 12, 2024

@kyle-ssg I've just retested this in the Uffizzi environment and it's not working. I'm sure that it previously was sending the correct data, but it seems like it's no longer doing so - I can't quite see why though.

This should include the use_custom_source attribute as well, but it's excluding it from the request.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants