Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send telemetry heartbeat post migrations are applied #3351

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

tushar5526
Copy link
Contributor

@tushar5526 tushar5526 commented Jan 30, 2024

Closes #3232

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Send telemetry heartbeats after migrations have been applied to skip the race condition mentioned in the issue.

How did you test this code?

Don't get any race conditions on applying migrations and running the project. Also ran the tests.

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 4:55pm

Copy link

vercel bot commented Jan 30, 2024

@tushar5526 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Uffizzi Preview deployment-45413 was deleted.

@dabeeeenster
Copy link
Contributor

Thanks!

@matthewelwell matthewelwell added this pull request to the merge queue Jan 30, 2024
@matthewelwell
Copy link
Contributor

Thanks again @tushar5526 !

Merged via the queue into Flagsmith:main with commit 31af594 Jan 30, 2024
19 of 21 checks passed
@tushar5526 tushar5526 deleted the fix/3232-race-condition branch January 30, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benign race condition error log in new Docker setup
3 participants