Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(staging/infra/redis): use correct connection factory #3353

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jan 31, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

fix DJANGO_REDIS_CONNECTION_FACTORY environment variable

How did you test this code?

Tested by deploying this to staging temporarily

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:07am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:07am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:07am

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Uffizzi Preview deployment-45444 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61537ce) 95.96% compared to head (c41d8a5) 18.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3353       +/-   ##
===========================================
- Coverage   95.96%   18.00%   -77.96%     
===========================================
  Files        1071      990       -81     
  Lines       32743    28560     -4183     
===========================================
- Hits        31421     5143    -26278     
- Misses       1322    23417    +22095     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit 4a5f5e6 Jan 31, 2024
10 checks passed
@gagantrivedi gagantrivedi deleted the throttling-fix-env-var branch January 31, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants