Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-usage): add environment variable to prevent API usage tracking. #3386

Merged

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Feb 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds an environment variable which controls whether API usage data is tracked.

Closes #2580.

How did you test this code?

Ran the docker compose file locally with the following settings:

      USE_POSTGRES_FOR_ANALYTICS: 'true'
      ENABLE_API_USAGE_TRACKING: 'false'

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 6, 2024 1:02pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Feb 6, 2024 1:02pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Feb 6, 2024 1:02pm

@matthewelwell matthewelwell requested review from a team and zachaysan and removed request for a team February 6, 2024 13:02
@github-actions github-actions bot added api Issue related to the REST API docs Documentation updates labels Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Uffizzi Preview deployment-45964 was deleted.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (16e6a28) 95.93% compared to head (f31eb1a) 18.04%.
Report is 4 commits behind head on main.

Files Patch % Lines
api/app/settings/common.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3386       +/-   ##
===========================================
- Coverage   95.93%   18.04%   -77.89%     
===========================================
  Files        1077      996       -81     
  Lines       32944    28721     -4223     
===========================================
- Hits        31606     5184    -26422     
- Misses       1338    23537    +22199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 5fa0a1a Feb 6, 2024
22 checks passed
@matthewelwell matthewelwell deleted the feat(api-usage)/add-option-to-disable-api-usage-tracking branch February 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API docs Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurate API to keep flag analytics data but drop API traffic.
3 participants