Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a sample of Identities when creating a Segment #341

Closed
dabeeeenster opened this issue Sep 22, 2021 · 0 comments · Fixed by #890
Closed

Show a sample of Identities when creating a Segment #341

dabeeeenster opened this issue Sep 22, 2021 · 0 comments · Fixed by #890
Assignees
Labels
api Issue related to the REST API front-end Issue related to the React Front End Dashboard improvement Improvement to the existing platform

Comments

@dabeeeenster
Copy link
Contributor

dabeeeenster commented Sep 22, 2021

Overview

When creating a Segment it can be difficult to know if your rule definitions are targeting the intended subset of Identities. It would be helpful to show a sample list of identities for a particular Environment that the Segment is being defined in, and whether they would be part of the segment.

Solution

  1. Make the create/edit segment UI take over the primary view of the application, rather than as a modal popup.
  2. Split primary view into two parts, vertically separated. The left part of view should be the existing Segment UI (creating rules etc). The right part should show a list of Identities, and indicate whether they match the Segment or not.
  3. Every time the Segment definition changes, refresh the right hand list.

API changes

We should add a new endpoint that takes a segment definition, grabs a number of Identities, calculates if they are part of the Segment definition and returns the list to the front end.

Issues

Since we are only able to process Segments in one direction, we have to fall back to sampling of Identities. One potential addition to this feature would be the option to filter the sampling list based on Identity ID. Then users could specify an Identity if they knew an example identity they want to target.

@dabeeeenster dabeeeenster added api Issue related to the REST API front-end Issue related to the React Front End Dashboard improvement Improvement to the existing platform labels Sep 22, 2021
@kyle-ssg kyle-ssg linked a pull request Apr 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API front-end Issue related to the React Front End Dashboard improvement Improvement to the existing platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants