Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: audit paging #3421

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: audit paging #3421

merged 1 commit into from
Feb 15, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Fixes audit log paging, paged responses that have pagination UI need to be transformed so that it knows current page etc

How did you test this code?

Before:

image

After
image

@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 10:07am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 10:07am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 10:07am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 15, 2024
@kyle-ssg kyle-ssg linked an issue Feb 15, 2024 that may be closed by this pull request
Paging for multiple list views showing NaN #3329
Closed
4 tasks
@kyle-ssg kyle-ssg changed the title audit paging fix: audit paging Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited

Uffizzi Preview deployment-46618 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 32f3b0a Feb 15, 2024
21 checks passed
@matthewelwell matthewelwell deleted the fix/audit-paging branch February 15, 2024 10:38
@dabeeeenster dabeeeenster mentioned this pull request Feb 15, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@novakzaballa novakzaballa Awaiting requested review from novakzaballa

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paging for multiple list views showing NaN
2 participants
@kyle-ssg @matthewelwell