Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Versioning test - always login regardless of skip test #3424

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix: Versioning test - always login regardless of skip test #3424

merged 2 commits into from
Feb 15, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Currently, deploy to production e2e is failing due to the versioning test.

Tests always logout post-test, tests need to login regardless of skipping due to disabled flags.

How did you test this code?

  • Ran e2e against prod

@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 11:21am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 11:21am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 11:21am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 15, 2024
matthewelwell
matthewelwell approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor comment.

frontend/e2e/tests/versioning-tests.ts Show resolved Hide resolved
@kyle-ssg kyle-ssg added this pull request to the merge queue Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited

Uffizzi Preview deployment-46625 was deleted.

@kyle-ssg kyle-ssg changed the title fix: Versioning test - llways login regardless of skip test fix: Versioning test - always login regardless of skip test Feb 15, 2024
Merged via the queue into main with commit a04aafb Feb 15, 2024
17 of 20 checks passed
@kyle-ssg kyle-ssg deleted the fix/prod-e2e-skip-versioning branch February 15, 2024 11:16
@dabeeeenster dabeeeenster mentioned this pull request Feb 15, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyle-ssg @matthewelwell