Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): move feature_name index into its own migration file #3427

Merged

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Feb 15, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This PR shuffles the migrations in the app_analytics module that were added in this PR: #3420.

This achieves point 2 in the description of the issue here.

As discussed there, this is only a partial fix that will at least ensure that migration retries will succeed once the index has been created, even if the migration process is timed out.

How did you test this code?

  • Ran the 2 migrations forwards and backwards on an empty table to confirm that the happy path works correctly.
  • Ran the 2 migrations forwards and backwards on a database with 1,000,000 feature evaluation records
  • Ran the migrations up to and including 0002, added the index manually, then ran 0003 to confirm it handled the existence of the index correctly

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 6:46pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 6:46pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 6:46pm

Copy link
Contributor

github-actions bot commented Feb 15, 2024

Uffizzi Preview deployment-46653 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d63a289) 95.92% compared to head (6e30f03) 95.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3427   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files        1090     1091    +1     
  Lines       33949    33954    +5     
=======================================
+ Hits        32564    32569    +5     
  Misses       1385     1385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell marked this pull request as ready for review February 15, 2024 19:22
@matthewelwell matthewelwell added this pull request to the merge queue Feb 16, 2024
Merged via the queue into main with commit 39b7300 Feb 16, 2024
38 checks passed
@matthewelwell matthewelwell deleted the fix(analytics)/fix-feature-evaluation-raw-migration branch February 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants