Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(segments): add query param to exclude / include feature specific #3430

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds the BE logic for #3428. Will need frontend work before it can be properly resolved.

Adds a new query parameter to explicitly include / exclude feature specific segments.

How did you test this code?

Added new tests.

@matthewelwell matthewelwell requested review from a team and khvn26 and removed request for a team February 16, 2024 10:31
Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 10:38am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 10:38am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 10:38am

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Uffizzi Preview deployment-46690 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Feb 16, 2024
Merged via the queue into main with commit aa22aad Feb 16, 2024
23 checks passed
@matthewelwell matthewelwell deleted the feat(segments)/add-feature-specific-query-param branch February 16, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants