fix(segments): use API query param for feature-specific filter #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
kyle-ssg
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
|
NOTE: this cannot be merged until #3430 is merged and released! |
I've re-added the manual filter for now so that we can merge these PRs independently. |
kyle-ssg
approved these changes
Feb 16, 2024
matthewelwell
deleted the
fix(segments)/use-api-query-param-for-feature-specific-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
FE component to resolve #3428
Uses the API query parameter for filtering feature-specific segments added in #3430.
How did you test this code?
Ran the FE locally and verified that the query parameter was being added correctly to the request. Also verified that toggling the filter made the correct new request to the API.