Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enabled state filter (Frontend) #3542

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Mar 5, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Frontend functionality for filtering feature enabled state and feature value, based on #3541. This is controlled by the feature flag feature_enabled_state_filter.

image

Note: I believe the API is searching based on the project default_value/default_enabled, it should be based on the provided environment's feature state. We'd never want to filter based on defaults.

How did you test this code?

  • Search a feature by value / enabled state

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 8:33am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 8:33am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 8:33am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Mar 5, 2024
@kyle-ssg kyle-ssg changed the title feat: Enabled state filter feat: Enabled state filter (Frontend) Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Uffizzi Preview deployment-47807 was deleted.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good thus far, but just wanted to confirm that we're designing in a search field as well to match feature values based on boolean, string, and integer values.

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Mar 5, 2024

It’s an easy addition but I couldn’t imagine that common a use case , thinking about itI’ll do it as part of this pr

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but please hold off on merging this until the server issue you highlighted gets fixed.

Edit: Or wrap this all up under a feature flag so we can deploy and fix whenever we want.

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Apr 2, 2024

Yep its under a feature flag.

@kyle-ssg kyle-ssg marked this pull request as ready for review April 2, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter flags in dashboard based on flag state
2 participants