Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit): add segment deleted audit log #3585

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds an audit log record when a segment is deleted.

How did you test this code?

Added a new test.

@matthewelwell matthewelwell requested review from a team and khvn26 and removed request for a team March 8, 2024 16:01
Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 4:04pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 4:04pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 4:04pm

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Uffizzi Preview deployment-48098 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (a422888) to head (4baf0bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3585   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files        1099     1099           
  Lines       34160    34171   +11     
=======================================
+ Hits        32748    32759   +11     
  Misses       1412     1412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewelwell matthewelwell added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit e2b8a92 Mar 8, 2024
23 checks passed
@matthewelwell matthewelwell deleted the fix/add-segment-deleted-audit-log-message branch March 8, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants