Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add stale_flags_limit_days to Project serializer #3607

Merged

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Mar 13, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds the stale_flags_limit_days field to the project serializer so that it can be configured via the dashboard.

How did you test this code?

Added tests

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 10:16am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 10:16am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 10:16am

@github-actions github-actions bot added the api Issue related to the REST API label Mar 13, 2024
@matthewelwell matthewelwell requested review from a team and gagantrivedi and removed request for a team March 13, 2024 12:12
Copy link
Contributor

github-actions bot commented Mar 13, 2024

Uffizzi Preview deployment-48303 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.86%. Comparing base (974dfc5) to head (2953dcd).
Report is 2 commits behind head on main.

Files Patch % Lines
api/projects/serializers.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3607      +/-   ##
==========================================
- Coverage   95.86%   95.86%   -0.01%     
==========================================
  Files        1099     1099              
  Lines       34214    34252      +38     
==========================================
+ Hits        32798    32834      +36     
- Misses       1416     1418       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell changed the title fix: Add stale_flags_limit_days to Project serializer fix: Add stale_flags_limit_days to Project serializer (WIP) Mar 13, 2024
@matthewelwell matthewelwell marked this pull request as draft March 13, 2024 12:25
@matthewelwell matthewelwell removed the request for review from gagantrivedi March 13, 2024 12:25
@matthewelwell matthewelwell marked this pull request as ready for review March 13, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants