Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Summary of group permissions in the Project settings page #3629

Conversation

fabricanva
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

In the list of groups, the permissions that this one has were added to the row.
Screen Shot 2024-03-15 at 16 59 21

How did you test this code?

  • Create a group
  • Go to project setting page -> permissions
  • Select Groups
  • Add Permission
  • Refresh the page

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 8:51am

Copy link

vercel bot commented Mar 15, 2024

@fabricanva is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Mar 15, 2024
@dabeeeenster
Copy link
Contributor

Thanks so much! Will review!

Copy link
Contributor

github-actions bot commented Mar 16, 2024

Uffizzi Preview deployment-48462 was deleted.

@dabeeeenster dabeeeenster linked an issue Mar 18, 2024 that may be closed by this pull request
@kyle-ssg
Copy link
Member

Thank you very much @fabricanva

I edited the PR a little bit by componentising the permission summary, making them chips / tooltiping the remaining permissions. I'd like to use this in other areas!

image

@kyle-ssg kyle-ssg enabled auto-merge March 26, 2024 15:37
@kyle-ssg kyle-ssg added this pull request to the merge queue Mar 26, 2024
Merged via the queue into Flagsmith:main with commit da12c93 Mar 26, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More details in Project Settings view
4 participants