fix: No pagination when querying environments_v2
#3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested review from
a team and
matthewelwell
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zachaysan
approved these changes
Mar 25, 2024
Comment on lines
+87
to
+98
| assert results == [override_document, override_document] | ||
| wrapper.table.query.assert_has_calls( | ||
| [ | ||
| mocker.call( | ||
| KeyConditionExpression=mocker.ANY, | ||
| ), | ||
| mocker.call( | ||
| KeyConditionExpression=mocker.ANY, | ||
| ExclusiveStartKey=last_evaluated_key, | ||
| ), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
So just to make sure I'm understanding this correctly: All the pages are returned in a single call. The response to the client could potentially span multiple documents that could be quite long?
There was a problem hiding this comment.
Yep. We have a customer with thousands of identity overrides for a single feature which prompted us to come up with this fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3661 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 1099 1099
Lines 34457 34467 +10
=======================================
+ Hits 33034 33045 +11
+ Misses 1423 1422 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This adds pagination to
environments_v2querying code to allow returning more than 1MB of identity overrides.How did you test this code?
Added a unit test for the case when DDB query gets more than one page of results.