fix: Filter versioned features #3756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3756 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 1126 1126
Lines 35786 35793 +7
=======================================
+ Hits 34342 34350 +8
+ Misses 1444 1443 -1 ☔ View full report in Codecov by Sentry. |
|
@zachaysan feel free to turn on the feature_enabled_state_filter flag when this is in 🚀 |
matthewelwell
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes #3243
Replace the existing mechanism of filtering feature states with a new one that preselects fewer models and runs a slimmed down filter step to select features based on their most recent version.
How did you test this code?
Added a versioned section to an existing test and ensured that the most recent version is selected.