Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct JS code snippets syntax #3770

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

rolodato
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes several JS snippets by:

  • Adding missing delimiters
  • Wrap trait names with quotes when used as keys, in case they are needed (e.g. if TRAIT_NAME contains a ., the snippet would not be valid syntax)
  • Wrapping ... in inline comments to ensure the whole snippet is valid JS

How did you test this code?

Manually by viewing the generated snippets in a local environment.

image image

Please describe.

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 5:57pm

Copy link

vercel bot commented Apr 15, 2024

@rolodato is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

Uffizzi Preview deployment-50186 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Apr 16, 2024
Merged via the queue into Flagsmith:main with commit e2155d2 Apr 16, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants