feat: Show organisation name in HTML title #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rolodato
force-pushed
the
feat/sales-dashboard-titles
branch
from
846f713
to
6b50349
Compare
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3814 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 1103 1103
Lines 34801 34801
=======================================
Hits 33386 33386
Misses 1415 1415 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Add the organisation name to the HTML title.
This makes it easier to find URLs to specific organisations by searching for them in browser history, bookmarks, chat/email/etc, since the URLs on their own only have numbers like
/sales-dashboard/organisations/4.There are smarter ways to implement this but it works and YAGNI applies until we need to customise a different page's title.
How did you test this code?
Manually, inspecting HTML titles on different pages.