fix: Delete feature external resources when GitHub integration was deleted #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
novakzaballa
changed the title
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3836 +/- ##
==========================================
+ Coverage 95.92% 95.96% +0.04%
==========================================
Files 1122 1126 +4
Lines 35501 35786 +285
==========================================
+ Hits 34053 34342 +289
+ Misses 1448 1444 -4 ☔ View full report in Codecov by Sentry. |
novakzaballa
force-pushed
the
chore/delete-feature-external-resources-when-github-integration-was-deleted
branch
from
bdac2de
to
8749f88
Compare
novakzaballa
changed the title
novakzaballa
requested review from
a team and
khvn26
and removed request for
a team
khvn26
requested changes
Apr 24, 2024
api/integrations/github/models.py
Outdated
| @@ -47,3 +48,19 @@ class Meta: | |||
| name="unique_repository_data", | |||
| ) | |||
| ] | |||
|
|
|||
| @hook(BEFORE_DELETE) | |||
| def delete_feature_external_respurces( | |||
There was a problem hiding this comment.
Suggested change
| def delete_feature_external_respurces( | |
| def delete_feature_external_resources( |
There was a problem hiding this comment.
Good catch, was corrected
|
|
||
| FeatureExternalResource.objects.filter( | ||
| feature__in=self.project.features.all(), | ||
| type__in=[ |
There was a problem hiding this comment.
Do you think we need to add an index on FeatureExternalResource.type?
There was a problem hiding this comment.
Good idea, I added an index
| github_configuration: GithubConfiguration, | ||
| github_repository: GithubRepository, | ||
| mocker, |
There was a problem hiding this comment.
from pytest_mock import MockerFixture
Suggested change
| mocker, | |
| mocker: MockerFixture, |
api/integrations/github/models.py
Outdated
| ) | ||
|
|
||
| FeatureExternalResource.objects.filter( | ||
| feature__in=self.project.features.all(), |
There was a problem hiding this comment.
I'd avoid a SELECT * here:
Suggested change
| feature__in=self.project.features.all(), | |
| feature_id__in=self.project.features.values_list("id", flat=True), |
khvn26
approved these changes
Apr 24, 2024
novakzaballa
deleted the
chore/delete-feature-external-resources-when-github-integration-was-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…deleted
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
How did you test this code?