Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saas): add correct GITHUB env vars to all locations #3840

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

2 main changes:

  1. Fix secret reference in production web task definition for GITHUB_PEM environment variable
  2. Ensure that the GITHUB env vars are correctly set in both web and task processor definitions in both staging and production

How did you test this code?

N/a - needs testing as part of deployment

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview Apr 25, 2024 9:10am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 9:10am
flagsmith-frontend-staging 🔄 Building (Inspect) Visit Preview Apr 25, 2024 9:10am

@matthewelwell matthewelwell added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 12242c4 Apr 25, 2024
7 of 9 checks passed
@matthewelwell matthewelwell deleted the fix(saas)/github-PEM-secret-reference branch April 25, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants