Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sentry-FLAGSMITH-API-4BN): update permission method #3851

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Apr 29, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Update get_permitted_environments on APIKeyUser to add support for prefetch_metadata
Fixes: FLAGSMITH-API-4BN

How did you test this code?

Adds/updates unit tests

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 2:52am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 2:52am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 2:52am

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Uffizzi Preview deployment-50947 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (73d1f91) to head (f8179e0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3851      +/-   ##
==========================================
- Coverage   95.87%   95.87%   -0.01%     
==========================================
  Files        1129     1129              
  Lines       35788    35787       -1     
==========================================
- Hits        34310    34309       -1     
  Misses       1478     1478              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi requested review from a team, novakzaballa and zachaysan and removed request for a team April 29, 2024 08:24
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but consider using the new fixture that I've mentioned in this PR since I think the plan will be to replace all occurrences with that fixture where possible.

@gagantrivedi gagantrivedi force-pushed the fix/api-key-user/fetch-environments branch from 23b6bde to f8179e0 Compare April 30, 2024 02:47
Update get_permitted_environments on APIKeyUser to add
support for prefetch_metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants