Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: For Hubspot make the switch to unique org id #3863

Merged
merged 3 commits into from
May 1, 2024

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

We need to switch to a new field called orgid_unique for Hubspot. This change introduces that behavior and at the same time removes an extraneous None property at the same time.

How did you test this code?

Connected directly to Hubspot and tried different options, including without an organisation_id, with one, etc. The rest of the test suite is suitable for coverage.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:13pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:13pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:13pm

Copy link
Contributor

github-actions bot commented Apr 30, 2024

Uffizzi Preview deployment-51070 was deleted.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.86%. Comparing base (29ae2e9) to head (917b770).
Report is 1 commits behind head on main.

Files Patch % Lines
api/integrations/lead_tracking/hubspot/client.py 66.66% 1 Missing ⚠️
...ations/lead_tracking/hubspot/_hubspot_responses.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3863      +/-   ##
==========================================
- Coverage   95.87%   95.86%   -0.01%     
==========================================
  Files        1130     1130              
  Lines       35791    35795       +4     
==========================================
+ Hits        34313    34315       +2     
- Misses       1478     1480       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 54c2603 May 1, 2024
22 checks passed
@matthewelwell matthewelwell deleted the fix/hubspot_switch_to_unique_org_id branch May 1, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants