Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning): feature segments updated with version #3880

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ensures that FeatureSegments are updated with the correct environment feature version when an environment is migrated to use v2 versioning

How did you test this code?

Added an integration test.

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 9:45am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 9:45am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 9:45am

@github-actions github-actions bot added the api Issue related to the REST API label May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

Uffizzi Preview deployment-51198 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (5a0693b) to head (c62b581).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3880   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files        1131     1131           
  Lines       35839    35854   +15     
=======================================
+ Hits        34359    34374   +15     
  Misses       1480     1480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 08d4046 May 3, 2024
22 checks passed
@matthewelwell matthewelwell deleted the fix(versioning)/ensure-feature-segments-are-updated-with-version branch May 3, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants