fix: Ensure flags are set in code example #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
front-end
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
kyle-ssg
reviewed
May 8, 2024
| @@ -8,6 +8,9 @@ $flagsmith = Flagsmith::Client.new( | |||
| environment_key: '${envId}' | |||
| ) | |||
|
|
|||
| // Load the environment's flags locally | |||
| $flags = $flagsmith.get_environment_flags | |||
There was a problem hiding this comment.
should this be $flags = $flagsmith.get_environment_flags()
There was a problem hiding this comment.
Not in Ruby. Parens are optional, even with arguments.
kyle-ssg
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Ensure flags are set in code example for the ruby client.
How did you test this code?
Checked it out in Vercel