fix(versioning): handle mapping of environment to engine post v2 versioning migration #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
novakzaballa
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3913 +/- ##
==========================================
+ Coverage 95.94% 95.98% +0.04%
==========================================
Files 1135 1135
Lines 36087 36170 +83
==========================================
+ Hits 34624 34719 +95
+ Misses 1463 1451 -12 ☔ View full report in Codecov by Sentry. |
matthewelwell
deleted the
fix(versioning)/fix-issue-mapping-environment-to-engine
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes issue mapping environment to engine environment post v2 versioning merge.
Note that another option here would be to change the mapping function to use e.g. the
versioning_service.get_environment_feature_statesfunction, but this would result in database query issues.How did you test this code?
Added a specific unit test to replicate the issue seen in production.