Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Organisation id not numeric in organisation settings #3929

Merged

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Number of seats displayed in the Organisation Settings page is wrong because we are not calling the right endpoint. This is because we are receiving a string as parameter in the URL when we expect an integer.

How did you test this code?

Tested locally and manually by navigating to the organisation settings page and veifying the seats data displayed and that the calls to the API are correct.

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 5:32pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 5:32pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 5:32pm

Copy link
Contributor

github-actions bot commented May 11, 2024

Uffizzi Preview deployment-51598 was deleted.

@novakzaballa novakzaballa added this pull request to the merge queue May 11, 2024
Merged via the queue into main with commit 9e3746b May 11, 2024
21 checks passed
@novakzaballa novakzaballa deleted the fix/organisation-id-not-numeric-in-organisation-settings branch May 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants