Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add trailing slash to update group logic #3943

Merged
merged 1 commit into from
May 14, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add trailing slash to request in FE to update group. Fixes 405 error updating groups when hitting flagsmith or flagsmith-private-cloud images as an API.

How did you test this code?

N/a - trivial change

@matthewelwell matthewelwell requested review from a team and novakzaballa and removed request for a team May 14, 2024 15:47
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 3:50pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 3:50pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 3:50pm

Copy link
Contributor

github-actions bot commented May 14, 2024

Uffizzi Preview deployment-51700 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 95b14d1 May 14, 2024
21 checks passed
@matthewelwell matthewelwell deleted the fix/update-group-missing-trailing-slash branch May 14, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants