fix(versioning): prevent task from deleting all unrelated feature states / feature segments #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewelwell
requested review from
a team and
novakzaballa
and removed request for
a team
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3955 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 1135 1135
Lines 36396 36401 +5
=======================================
+ Hits 34945 34950 +5
Misses 1451 1451 ☔ View full report in Codecov by Sentry. |
gagantrivedi
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Previously the endpoint to revert feature versioning attempted to delete all feature states in the platform. This PR resolves that by ensuring that we filter everything on the environment.
How did you test this code?
Updated the unit test after first confirming that it failed with the current code.