Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change environment in settings page #3956

Merged
merged 1 commit into from
May 15, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Switching an environment will now update the settings pages.

How did you test this code?

  • Switch environment on the settings page and other tabs

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 0:43am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 0:43am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 0:43am

Copy link
Contributor

github-actions bot commented May 15, 2024

Uffizzi Preview deployment-51757 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 0d30180 May 15, 2024
21 checks passed
@matthewelwell matthewelwell deleted the fix/change-environment-in-settings branch May 15, 2024 14:33
Copy link

sentry-io bot commented May 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of null (reading 'find') getEnvironment(web/components/pages/Environment... View Issue
  • ‼️ TypeError: E.getRolesEnvironmentPermissions is not a function then(web/components/pages/EnvironmentSettingsPage) View Issue
  • ‼️ TypeError: E.getRolesEnvironmentPermissions is not a function then(web/components/pages/EnvironmentSettingsPage) View Issue
  • ‼️ TypeError: E.getRolesEnvironmentPermissions is not a function then(web/components/pages/EnvironmentSettingsPage) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment settings not updated when switching environments
2 participants