Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Hook sends only one type of event (FLAG_UPDATED) #72

Open
GennadiiSvichinskyi opened this issue Jan 9, 2021 · 5 comments
Open

Web Hook sends only one type of event (FLAG_UPDATED) #72

GennadiiSvichinskyi opened this issue Jan 9, 2021 · 5 comments
Assignees
@dabeeeenster @p-maks @matthewelwell
Labels
feature New feature or request good first issue Good for newcomers tech-debt Technical debt issues
Milestone
Audit Log Refactor

Comments

@GennadiiSvichinskyi
Copy link

Hi,

It is quite stupid to have one type for many events.
Suggestion:
On feature_segment update sends : FLAG_SEGMENT_UPDATED
On feature_identity update sends : FLAG_IDENTITY_UPDATED
on feature update sends : FLAG_FEATURE_UPDATED
@dabeeeenster dabeeeenster added feature New feature or request good first issue Good for newcomers labels Jan 11, 2021
@dabeeeenster
Copy link
Contributor

Thanks - added to the backlog

@dabeeeenster dabeeeenster added this to the Audit Log Refactor milestone Feb 15, 2022
@dabeeeenster dabeeeenster added the tech-debt Technical debt issues label Feb 15, 2022
@aspidites
Copy link
Contributor

@dabeeeenster , is it cool if I take a stab at this one?

@dabeeeenster
Copy link
Contributor

Actually this is being handled by work @matthewelwell is doing I believe

@aspidites aspidites mentioned this issue Jun 17, 2023
Closed
6 tasks
@aspidites
Copy link
Contributor

Ooh, Completely missed that. I'll close my PR then.

@dabeeeenster dabeeeenster linked a pull request Jun 19, 2023 that will close this issue
Feature/more webhook event types #2310
Closed
6 tasks
@dabeeeenster
Copy link
Contributor

dabeeeenster commented Jun 19, 2023 •
edited

Ah looks like this already has a PR! #2310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dabeeeenster dabeeeenster

@p-maks p-maks

@matthewelwell matthewelwell

Labels
feature New feature or request good first issue Good for newcomers tech-debt Technical debt issues
Projects
None yet
Milestone
Audit Log Refactor
Development

Successfully merging a pull request may close this issue.

Feature/more webhook event types aspidites/flagsmith
5 participants
@aspidites @dabeeeenster @p-maks @matthewelwell @GennadiiSvichinskyi